Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icon): mirror directional icons in RTL #4141

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

HeartSquared
Copy link
Contributor

@HeartSquared HeartSquared commented Oct 6, 2023

Why

POC mirroring directional icons which should point in the opposite direction in RTL.

image

What

  • Add RTLMirror helper component
  • Update ArrowBackward and ArrowForward to mirror in RTL

Note

There is a slight conflict with icons which need this functionality, in that our update-icons script will rewrite and undo the implementation if there is a matching svg asset.

@changeset-bot
Copy link

changeset-bot bot commented Oct 6, 2023

⚠️ No Changeset found

Latest commit: f499bd6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant