Fix circular depenacies across multiple component types #5454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a55a1c7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mcwinter07
force-pushed
the
KZN-2947/circular-dep-fixes
branch
from
61e1dd8 to
205382f
Compare
dougmacknz
approved these changes
Jan 20, 2025
Comment on lines
8
to
9
| type MeaningfulSVG = { 'role': 'img'; 'aria-label': string; 'alt'?: never } | ||
| type DecorativeSVG = { 'role': 'presentation'; 'aria-label'?: never; 'alt'?: never } |
There was a problem hiding this comment.
You've defined this in types.ts now, so better to export and import from there rather than have the duplication :)
Alt move all the types in there 😬
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This is part of an attempt to reduce or remove the hang time for our build in CI. After reading this post on the impact of circular dependencies with Vite, this could be the cause of our unknown hang time.
Finding the circular deps
To ID the problem files I ran
madgeagainst out components src folder which returned the following:If you want to run this you will need install or run madge via npx then run this from the root our repo:
npx madge --extensions ts,tsx --ts-config=tsconfig.json packages/components/src -cI've left the scss function unchange as I wasn't sure how this was causing a circular dep. the -mui helper are part of legacy vendor support and ideally should be removed / shifted into kaizen legacy.
What