-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc improvements including ALLOW_FILES
and NEW_NOTE_NOTICE
#119
Conversation
Thats super nice! Thanks 🚀 will have a look the coming days. |
@@ -3,7 +3,8 @@ | |||
</script> | |||
|
|||
<script lang="ts"> | |||
import { saveAs } from 'file-saver' | |||
import pkg from 'file-saver' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we could inline the actual import, it's only one file. But I can do it in a later time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice but as far as I know, there is no way to make it one line as long as file-saver
is CJS (in its current form). It seems like that package hasn't been updated for 3 years now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean like removing the dependency, and just copy pasta the actual library into the code base. It's 1 file. But i'll do it in another PR :)
@cupcakearmy updated the name of the flag! |
Hi,
We at Compass really like this project and are planning to deploy a version ourselves. We need a few extra configurable features that I hope will mesh well with upstream.
The changes in the PR are:
file-saver
being a CommonJS moduleALLOW_FILES
flag which lets the user disable file uploads@types/node
NEW_NOTE_NOTICE
flag which lets you hide the notice about it being stored in the RAM etc (this would just confuse non-technical users)Let me know if you want any changes/improvements/if this doesn't fit well with upstream/etc.
Best
Tamas
P.S: There may be more to come but this is a good first batch.