Use Macro.to_string/1 instead of parsing specs by "hand"
#34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blatts12
changed the title
[][], integer, range and bitstrings
Blatts12
changed the title
[], integer, range and bitstrings[], integer, range, bitstrings, nested types and guards
Blatts12
changed the title
[], integer, range, bitstrings, nested types and guards[], integer, range, bitstrings and nested types
Blatts12
changed the title
[], integer, range, bitstrings and nested typesMacro.to_string/1 instead of parsing specs by "hand"
szsoppa
reviewed
Oct 12, 2023
lib/contexted/module_analyzer.ex
Outdated
| defp format_type({:type, _, type_name, _}, _module), do: "#{type_name}()" | ||
| @spec build_spec(tuple()) :: String.t() | ||
| defp build_spec({{function_name, _arity}, spec}) do | ||
| first_spec = hd(spec) |
There was a problem hiding this comment.
Does it mean there can be more of these? Meaning, does spec hold multiple definitions of specs?
There was a problem hiding this comment.
It does hold multiple specs for one function. I have added support for multiple specs.
szsoppa
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.