testing nvim 0.9.5

cursorless-dev · May 16, 2024 · 1cecf83 · 1cecf83
1 parent 3c90337
commit 1cecf83
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -18,7 +18,11 @@ jobs:
         # XXX: restore this once neovim tests work in CI
         # os: [macos-latest, ubuntu-latest, windows-latest]
         os: [windows-latest]
-        app_version: [stable]
+        # XXX - stable is 0.10.0 and only has nvim.exe (no nvim-qt.exe). Also locally it hangs on unskipped test
+        # and on CI, it fails on trying to tail the log and I don't know what is happening since didnt get a snapshot of CI yet
+        # to understand the error in nvim.exe (though probably need the nvim-qt.exe since nvim.exe won't show anything)
+        # app_version: [stable]
+        app_version: [v0.9.5]
         # XXX: restore this once neovim tests work in CI
         # include:
         #   - os: ubuntu-latest

diff --git a/packages/test-harness/src/launchNeovimAndRunTests.ts b/packages/test-harness/src/launchNeovimAndRunTests.ts
@@ -47,9 +47,9 @@ export async function launchNeovimAndRunTests(extensionTestsPath: string) {
     // const vscodeExecutablePath = await downloadAndUnzipVSCode(vscodeVersion);
     // const [cli, ...args] =
     //   resolveCliArgsFromVSCodeExecutablePath(vscodeExecutablePath);
-    const cli = getEnvironmentVariableStrict("APP_PATH");
+    let cli = getEnvironmentVariableStrict("APP_PATH");
     // Installed executable: C:\Users\runneradmin\nvim-stable\bin\nvim.exe
-    //cli = cli.replace("nvim.exe", "nvim-qt.exe");
+    cli = cli.replace("nvim.exe", "nvim-qt.exe");
     /*
       node:events:496
             throw er; // Unhandled 'error' event