Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scope test machinery for remaining languages #2326

Merged
merged 18 commits into from
May 15, 2024
Merged

Add scope test machinery for remaining languages #2326

merged 18 commits into from
May 15, 2024

Conversation

AndreasArvidsson
Copy link
Member

Checklist

  • I have added tests
  • [/] I have updated the docs and cheatsheet
  • [/] I have not broken the cheatsheet

@AndreasArvidsson AndreasArvidsson requested a review from pokey as a code owner May 11, 2024 13:18
@pokey pokey changed the title Make sure all languages have at least one scope test Add scope test machinery for clojure and go May 12, 2024
pokey
pokey reviewed May 12, 2024
View reviewed changes
Copy link
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but remove

cursorless/packages/cursorless-engine/src/languages/getTextFragmentExtractor.ts

Lines 118 to 121 in bccc6d8

clojure: constructDefaultTextFragmentExtractor(
"clojure",
constructHackedStringTextFragmentExtractor("clojure"),
),

@AndreasArvidsson
Copy link
Member Author

done

@AndreasArvidsson AndreasArvidsson requested a review from pokey May 14, 2024 15:39
@AndreasArvidsson AndreasArvidsson changed the title Add scope test machinery for clojure and go Add scope test machinery for clojure, go, cpp May 14, 2024
pokey
pokey approved these changes May 15, 2024
View reviewed changes
data/fixtures/scopes/markdown/comment.line.scope
Comment on lines +7 to +8
>---------------------<
0| <!-- Hello World -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh this looks wrong; includes the leading space. Out of scope for this PR tho

@pokey pokey changed the title Add scope test machinery for clojure, go, cpp Add scope test machinery for remaining languages May 15, 2024
@pokey pokey added this pull request to the merge queue May 15, 2024
Merged via the queue into main with commit dbb5fb8 May 15, 2024
15 checks passed
@pokey pokey deleted the scopes branch May 15, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pokey pokey pokey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndreasArvidsson @pokey