Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added performance tests #2697

Merged
merged 20 commits into from
Jan 7, 2025
Merged

Added performance tests #2697

merged 20 commits into from
Jan 7, 2025

Conversation

AndreasArvidsson
Copy link
Member

@AndreasArvidsson AndreasArvidsson commented Dec 14, 2024

The tests should pass once #2700 is merged

This is the result from running it locally on my desktop.

  Performance: 10202 lines JSON
    Remove token
      24 ms
    √ Remove token (108ms)
    Select character
      14 ms
    √ Select character (122ms)
    Select word
      10 ms
    √ Select word (113ms)
    Select token
      8 ms
    √ Select token (110ms)
    Select identifier
      7 ms
    √ Select identifier (115ms)
    Select line
      40 ms
    √ Select line (141ms)
    Select sentence
      25 ms
    √ Select sentence (126ms)
    Select paragraph
      5 ms
    √ Select paragraph (104ms)
    Select document
      8 ms
    √ Select document (115ms)
    Select nonWhitespaceSequence
      8 ms
    √ Select nonWhitespaceSequence (96ms)
    Select string
      247 ms
    √ Select string (353ms)
    Select map
      167 ms
    √ Select map (248ms)
    Select collectionKey
      135 ms
    √ Select collectionKey (223ms)
    Select value
      142 ms
    √ Select value (222ms)
    Select boundedParagraph
      11822 ms
    √ Select boundedParagraph (11906ms)
    Select boundedNonWhitespaceSequence
      13749 ms
    √ Select boundedNonWhitespaceSequence (13837ms)
    Select surroundingPair.any
      20893 ms
    √ Select surroundingPair.any (21039ms)
    Select surroundingPair.curlyBrackets
      365 ms
    √ Select surroundingPair.curlyBrackets (483ms)
  18 passing (50s)

Checklist

  • I have added tests
  • [-] I have updated the docs and cheatsheet
  • [-] I have not broken the cheatsheet

@AndreasArvidsson AndreasArvidsson requested a review from a team as a code owner December 14, 2024 15:26
@AndreasArvidsson
Copy link
Member Author

@pokey Mind having a look at this? Once this is in I have a baseline to compare the collection items scope handler against.

@AndreasArvidsson
Copy link
Member Author

The tests should pass once #2700 is merged

Copy link
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@pokey pokey added this pull request to the merge queue Jan 7, 2025
Merged via the queue into main with commit 1bffae5 Jan 7, 2025
15 checks passed
@pokey pokey deleted the performance branch January 7, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants