Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for browser rpc #2704

Merged
merged 8 commits into from
Jan 7, 2025
Merged

Added support for browser rpc #2704

merged 8 commits into from
Jan 7, 2025

Conversation

AndreasArvidsson
Copy link
Member

When using Cursorless everywhere in Talon js the accessibility is not good enough for browsers. I'm working on my own browser extension to mitigate this.

What this pull request is doing is adding a new Cursorless everywhere context. When the new tag is set Cursorless everywhere will use the command client instead of access ability.

Checklist

  • [/] I have added tests
  • [/] I have updated the docs and cheatsheet
  • [/] I have not broken the cheatsheet

@AndreasArvidsson AndreasArvidsson requested a review from a team as a code owner December 31, 2024 10:08
Copy link
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked closely, but it is well contained so I won't stand in the way. Maybe @phillco has opinions here

Also of course looking at how rango does things for browser rpc as that is quite battle tested at this point

@AndreasArvidsson
Copy link
Member Author

I haven't looked closely, but it is well contained so I won't stand in the way. Maybe @phillco has opinions here

Also of course looking at how rango does things for browser rpc as that is quite battle tested at this point

Rango uses the clipboard and we are using the command client. I think our implementation is much better.

@pokey
Copy link
Member

pokey commented Jan 7, 2025

Fine I won't stand in the way of this one

@AndreasArvidsson AndreasArvidsson changed the title Added support for browser rp Added support for browser rpc Jan 7, 2025
@AndreasArvidsson AndreasArvidsson added this pull request to the merge queue Jan 7, 2025
Merged via the queue into main with commit d113d88 Jan 7, 2025
15 checks passed
@AndreasArvidsson AndreasArvidsson deleted the browserRpc branch January 7, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants