Add GDScript to supported languages #3092
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, that's the point actually, it's a work in progress!!!
…, that's the point actually, it's a work in progress!!!
…nto gdscript-support
|
You need to run prettier. That is what pre commit is complaining about. |
| "mrob95.vscode-talonscript", // talon | ||
| "jrieken.vscode-tree-sitter-query", // scm | ||
| "mathiasfrohlich.kotlin", // kotlin | ||
| "geequlim.godot-tools", //gdscript |
There was a problem hiding this comment.
Suggested change
| "geequlim.godot-tools", //gdscript | |
| "geequlim.godot-tools", // gdscript |
| import type { LanguageScopeSupportFacetMap } from "./scopeSupportFacets.types"; | ||
| import { ScopeSupportFacetLevel } from "./scopeSupportFacets.types"; | ||
|
|
||
| //eslint-disable-next-line |
There was a problem hiding this comment.
Suggested change
| //eslint-disable-next-line | |
| // eslint-disable-next-line |
AndreasArvidsson
requested changes
Oct 13, 2025
There was a problem hiding this comment.
Not a big fan of committing an empty file. Please add at least one scope to it. You can do something simple like comment for example.
There was a problem hiding this comment.
Going to need to make another PR to add another codium cli naming related fix first so I can more easily do that, but once that's done that should be easy enough
There was a problem hiding this comment.
See #3093 for the fixes mentioned above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't actually implement any scopes (though it does define a few as being
notApplicable), but defines gdscript (.gd) as a supported language, easing further development by not requiring me to run a local build of Cursorless when working on actual scope implementations in the future. This has been done for quite a while but I've not had the time to submit the PR until now due to a generally stressful fall semester and catching COVID during the first week of classes, so I thought I'd get the PR in now before I forget again >.<