fix: onchain reverts #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 4, 2025
AlbertoCentonze
force-pushed
the
vp-rounding-fix
branch
from
fe52c34 to
8621f90
Compare
AlbertoCentonze
force-pushed
the
onchain-reverts
branch
from
a7ab1a5 to
69ab966
Compare
AlbertoCentonze
force-pushed
the
vp-rounding-fix
branch
from
8621f90 to
c0917de
Compare
AlbertoCentonze
force-pushed
the
onchain-reverts
branch
2 times, most recently
from
7640a92 to
b4e65fb
Compare
AlbertoCentonze
force-pushed
the
onchain-reverts
branch
from
b4e65fb to
bc6b635
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically Curve pools have been using dev reasons for errors to reduce the impact on codesize due to EIP-170 limitations. However given the increasing amount of integrators for the cryptoswap algo, dev reasons have proven to be very hard to use for debugging for devs that are not using titanoboa.
Given twocrypto-ng has enough room to add onchain errors, I replaced all dev reasons with more tooling friendly onchain reverts.
This is part 3 of 3 in a stack made with GitButler: