Add handleActionConfig to allow people to run their own ActionConfig #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, this one got lost in the shuffle of life. I didn't want to deal with the conflicts so just pushed your change myself and is in release 1.6.8. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I seperated out the actual executing of the ActionConfig and the grabbing of the ActionConfig to allow for people to provide their own ActionConfig.
I needed to add my own press_action and release_action (custom-cards/button-card#360), if this is merged this can easily be added by providing the actionconfig they want to run to handleActionConfig instead of the action that was performed to handleAction.