Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add endpoint docs to README #2

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Add endpoint docs to README #2

merged 2 commits into from
Nov 2, 2023

Conversation

nunofgs
Copy link
Collaborator

@nunofgs nunofgs commented Oct 31, 2023

No description provided.

Copy link

@mwycio mwycio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Nuno, just left a comment

if err != nil {
panic(err)
}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to close the connection here i.e. client.Close()?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a ... to indicate that this is just an example. The first example at the top of the README already includes it.

@nunofgs nunofgs merged commit d9af6a6 into main Nov 2, 2023
4 checks passed
@nunofgs nunofgs deleted the add-endpoint-to-readme branch November 2, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants