pr suggestions #1782
This run and associated checks have been archived and are scheduled for deletion.
Learn more about checks retention
Annotations
36 warnings
Kotlin Lint
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-java@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Android Lint (sdk)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-java@v2, yutailang0119/[email protected]. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Android Lint (sdk):
sdk/src/main/java/io/customer/sdk/CustomerIO.kt#L554
'getActivityInfo(ComponentName, Int): ActivityInfo' is deprecated. Deprecated in Java
|
|
Android Lint (sdk):
sdk/src/main/java/io/customer/sdk/data/store/ApplicationStore.kt#L24
'getPackageInfo(String, Int): PackageInfo!' is deprecated. Deprecated in Java
|
Android Lint (sdk):
sdk/src/main/java/io/customer/sdk/repository/DeviceRepository.kt#L34
Name shadowed: attributes
|
Android Lint (sdk):
sdk/src/main/java/io/customer/sdk/repository/ProfileRepository.kt#L39
Name shadowed: currentlyIdentifiedProfileIdentifier
|
Android Lint (sdk):
common-test/src/main/java/io/customer/commontest/util/DispatchersProviderStub.kt#L7
'TestCoroutineDispatcher' is deprecated. The execution order of `TestCoroutineDispatcher` can be confusing, and the mechanism of pausing is typically misunderstood. Please use `StandardTestDispatcher` or `UnconfinedTestDispatcher` instead.
|
Android Lint (sdk):
common-test/src/main/java/io/customer/commontest/util/DispatchersProviderStub.kt#L24
'TestCoroutineDispatcher' is deprecated. The execution order of `TestCoroutineDispatcher` can be confusing, and the mechanism of pausing is typically misunderstood. Please use `StandardTestDispatcher` or `UnconfinedTestDispatcher` instead.
|
Android Lint (sdk):
common-test/src/main/java/io/customer/commontest/util/DispatchersProviderStub.kt#L28
'TestCoroutineDispatcher' is deprecated. The execution order of `TestCoroutineDispatcher` can be confusing, and the mechanism of pausing is typically misunderstood. Please use `StandardTestDispatcher` or `UnconfinedTestDispatcher` instead.
|
Android Lint (sdk):
sdk/src/main/java/io/customer/sdk/data/moshi/adapter/CustomAttributesAdapter.kt#L74
Ignoring results: The result of `toJson` is not used
|
Android Lint (sdk):
sdk/src/debug/AndroidManifest.xml#L7
Attribute unused on older versions: Attribute `networkSecurityConfig` is only used in API level 24 and higher (current min is 21)
|
Android Lint (messaginginapp)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-java@v2, yutailang0119/[email protected]. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Android Lint (messaginginapp):
messaginginapp/src/main/res/values-v21#L1
Obsolete SDK_INT Version Check: This folder configuration (`v21`) is unnecessary; `minSdkVersion` is 21. Merge all the resources in this folder into `values`.
|
Android Lint (messaginginapp):
sdk/src/main/java/io/customer/sdk/CustomerIO.kt#L554
'getActivityInfo(ComponentName, Int): ActivityInfo' is deprecated. Deprecated in Java
|
|
Android Lint (messaginginapp):
sdk/src/main/java/io/customer/sdk/data/store/ApplicationStore.kt#L24
'getPackageInfo(String, Int): PackageInfo!' is deprecated. Deprecated in Java
|
Android Lint (messaginginapp):
sdk/src/main/java/io/customer/sdk/repository/DeviceRepository.kt#L34
Name shadowed: attributes
|
Android Lint (messaginginapp):
sdk/src/main/java/io/customer/sdk/repository/ProfileRepository.kt#L39
Name shadowed: currentlyIdentifiedProfileIdentifier
|
Android Lint (messaginginapp):
messaginginapp/src/main/java/io/customer/messaginginapp/ModuleMessagingInApp.kt#L30
Parameter 'organizationId' is never used
|
Android Lint (messaginginapp):
messaginginapp/src/main/java/io/customer/messaginginapp/gist/data/listeners/Queue.kt#L71
This is a delicate API and its use requires care. Make sure you fully read and understand documentation of the declaration that is marked as a delicate API.
|
Android Lint (messaginginapp):
messaginginapp/src/main/java/io/customer/messaginginapp/gist/data/listeners/Queue.kt#L138
This is a delicate API and its use requires care. Make sure you fully read and understand documentation of the declaration that is marked as a delicate API.
|
Android Lint (messaginginapp):
messaginginapp/src/main/java/io/customer/messaginginapp/gist/data/model/Message.kt#L36
Unchecked cast: Any to Map<String, Any?>
|
Android Lint (messaginginapp):
messaginginapp/src/main/java/io/customer/messaginginapp/gist/data/model/Message.kt#L36
Name shadowed: gistProperties
|
Android Lint (messagingpush)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-java@v2, yutailang0119/[email protected]. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Android Lint (messagingpush):
sdk/src/main/java/io/customer/sdk/CustomerIO.kt#L554
'getActivityInfo(ComponentName, Int): ActivityInfo' is deprecated. Deprecated in Java
|
|
Android Lint (messagingpush):
sdk/src/main/java/io/customer/sdk/data/store/ApplicationStore.kt#L24
'getPackageInfo(String, Int): PackageInfo!' is deprecated. Deprecated in Java
|
Android Lint (messagingpush):
sdk/src/main/java/io/customer/sdk/repository/DeviceRepository.kt#L34
Name shadowed: attributes
|
Android Lint (messagingpush):
sdk/src/main/java/io/customer/sdk/repository/ProfileRepository.kt#L39
Name shadowed: currentlyIdentifiedProfileIdentifier
|
Android Lint (messagingpush):
messagingpush/src/main/java/io/customer/messagingpush/CustomerIOPushNotificationHandler.kt#L133
'getApplicationInfo(String, Int): ApplicationInfo' is deprecated. Deprecated in Java
|
Android Lint (messagingpush):
messagingpush/src/main/java/io/customer/messagingpush/CustomerIOPushReceiver.kt#L43
'getParcelable(String?): T?' is deprecated. Deprecated in Java
|
Android Lint (messagingpush):
common-test/src/main/java/io/customer/commontest/util/DispatchersProviderStub.kt#L7
'TestCoroutineDispatcher' is deprecated. The execution order of `TestCoroutineDispatcher` can be confusing, and the mechanism of pausing is typically misunderstood. Please use `StandardTestDispatcher` or `UnconfinedTestDispatcher` instead.
|
Android Lint (messagingpush):
common-test/src/main/java/io/customer/commontest/util/DispatchersProviderStub.kt#L24
'TestCoroutineDispatcher' is deprecated. The execution order of `TestCoroutineDispatcher` can be confusing, and the mechanism of pausing is typically misunderstood. Please use `StandardTestDispatcher` or `UnconfinedTestDispatcher` instead.
|
Android Lint (messagingpush):
common-test/src/main/java/io/customer/commontest/util/DispatchersProviderStub.kt#L28
'TestCoroutineDispatcher' is deprecated. The execution order of `TestCoroutineDispatcher` can be confusing, and the mechanism of pausing is typically misunderstood. Please use `StandardTestDispatcher` or `UnconfinedTestDispatcher` instead.
|
Android Lint (messagingpush):
messagingpush/src/main/java/io/customer/messagingpush/extensions/ContextExtensions.kt#L18
Using discouraged APIs: Use of this function is discouraged because resource reflection makes it harder to perform build optimizations and compile-time verification of code. It is much more efficient to retrieve resources by identifier (e.g. `R.foo.bar`) than by name (e.g. `getIdentifier("bar", "foo", null)`).
|