-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add activity to handle push click #249
chore: add activity to handle push click #249
Conversation
Pull request title looks good 👍! If this pull request gets merged, it will not cause a new release of the software. Example: If this project's latest release version is All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time. This project uses a special format for pull requests titles. Expand this section to learn more (expand by clicking the ᐅ symbol on the left side of this sentence)...This project uses a special format for pull requests titles. Don't worry, it's easy! This pull request title should be in this format:
If your pull request introduces breaking changes to the code, use this format:
where
Examples:
Need more examples? Want to learn more about this format? Check out the official docs. Note: If your pull request does multiple things such as adding a feature and makes changes to the CI server and fixes some bugs then you might want to consider splitting this pull request up into multiple smaller pull requests. |
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.
|
Codecov Report
@@ Coverage Diff @@
## rehan/push-click-behavior #249 +/- ##
===============================================================
- Coverage 50.78% 49.61% -1.18%
- Complexity 249 250 +1
===============================================================
Files 108 110 +2
Lines 2786 2858 +72
Branches 366 374 +8
===============================================================
+ Hits 1415 1418 +3
- Misses 1255 1322 +67
- Partials 116 118 +2
|
Build available to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, github is giving me error messages while trying to leave inline comments.
Before I leave those, I do want to point out that github annotations are showing up for many lint errors for deprecated code being used and automated tests not being written.
Do you plan on adding automated tests for this PR and addressing lint warnings?
Hopefully by the time you address these concerns, github will no longer give me errors can I can leave a more detailed review!
...ngpush/src/main/java/io/customer/messagingpush/activity/NotificationClickReceiverActivity.kt
Show resolved
Hide resolved
messagingpush/src/main/java/io/customer/messagingpush/config/NotificationClickBehavior.kt
Show resolved
Hide resolved
@levibostian I think the only deprecated code we are using in this PR is what isn't available on older APIs. I fixed one small issue. Please feel free to point any are that is still using deprecated code. For tests, I think a lot of changes we made in this PR rely on Android OS callbacks. So testing them may be quite hard with mocks, but I do plan to write some tests. And they will probably be coming in the last PR for this feature (after wrapper ones). |
I would prefer that tests get added to this PR because it does make reviewing much easier. GitHub gives you annotations helping you find parts of the code missing tests. If a future PR was made adding tests, the annotations would not show up and therefore, would make reviewing the PR for missing tests much harder. As far as the deprecations, I also use github annotations to highlight them. There are lint warnings that are annotated (see screenshot above). I suggest enabling them if you have not already. |
The deprecations shown are for existing code, not the code added in this PR. Fixing the warnings is definitely a good idea, but this PR isn't the right place for those updates. Holding up this PR for tests complicates testing and finalizing changes on wrapper SDKs. The PRs were split to keep them short and simplify reviews. I'll write tests after validating changes in the wrapper SDKs. Since this PR is merging into a feature PR, we can still use GitHub annotations to identify code that isn't covered with tests. |
helps: https://github.com/customerio/issues/issues/10830
Changes
NotificationClickReceiverActivity
for handling notification clicksNotificationClickBehavior
for customizing notification click behaviorDeepLinkUtil
updates to avoid adding unwanted flags to intentsNotes
NotificationClickBehavior
may be re-reviewed after feature changes are complete so we have clear picture of there implementation and behavior with different sample apps