Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove CustomerIOPushReceiver #250

Merged
merged 27 commits into from
Sep 26, 2023

Conversation

mrehan27
Copy link
Contributor

@mrehan27 mrehan27 commented Sep 7, 2023

helps: https://github.com/customerio/issues/issues/10830

Changes

  • Removed CustomerIOPushReceiver in favor of NotificationClickReceiverActivity
  • Updated DeepLinkUtil to remove unused code

@mrehan27 mrehan27 requested a review from a team September 7, 2023 11:34
@mrehan27 mrehan27 self-assigned this Sep 7, 2023
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Pull request title looks good 👍!

If this pull request gets merged, it will not cause a new release of the software. Example: If this project's latest release version is 1.0.0. If this pull request gets merged in, the next release of this project will be 1.0.0. This pull request is not a breaking change.

All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time.

This project uses a special format for pull requests titles. Expand this section to learn more (expand by clicking the ᐅ symbol on the left side of this sentence)...

This project uses a special format for pull requests titles. Don't worry, it's easy!

This pull request title should be in this format:

<type>: short description of change being made

If your pull request introduces breaking changes to the code, use this format:

<type>!: short description of breaking change

where <type> is one of the following:

  • feat: - A feature is being added or modified by this pull request. Use this if you made any changes to any of the features of the project.

  • fix: - A bug is being fixed by this pull request. Use this if you made any fixes to bugs in the project.

  • docs: - This pull request is making documentation changes, only.

  • refactor: - A change was made that doesn't fix a bug or add a feature.

  • test: - Adds missing tests or fixes broken tests.

  • style: - Changes that do not effect the code (whitespace, linting, formatting, semi-colons, etc)

  • perf: - Changes improve performance of the code.

  • build: - Changes to the build system (maven, npm, gulp, etc)

  • ci: - Changes to the CI build system (Travis, GitHub Actions, Circle, etc)

  • chore: - Other changes to project that don't modify source code or test files.

  • revert: - Reverts a previous commit that was made.

Examples:

feat: edit profile photo
refactor!: remove deprecated v1 endpoints
build: update npm dependencies
style: run formatter 

Need more examples? Want to learn more about this format? Check out the official docs.

Note: If your pull request does multiple things such as adding a feature and makes changes to the CI server and fixes some bugs then you might want to consider splitting this pull request up into multiple smaller pull requests.

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.


  • java_layout: rehan/push-click-cleanup (1695703783)
  • kotlin_compose: rehan/push-click-cleanup (1695703789)

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #250 (22f85cd) into rehan/push-click-behavior (f7665c1) will increase coverage by 0.83%.
The diff coverage is 0.00%.

@@                       Coverage Diff                       @@
##             rehan/push-click-behavior     #250      +/-   ##
===============================================================
+ Coverage                        50.12%   50.95%   +0.83%     
+ Complexity                         250      249       -1     
===============================================================
  Files                              110      109       -1     
  Lines                             2879     2769     -110     
  Branches                           382      351      -31     
===============================================================
- Hits                              1443     1411      -32     
+ Misses                            1320     1240      -80     
- Partials                           116      118       +2     
Files Coverage Δ
...messagingpush/CustomerIOPushNotificationHandler.kt 0.00% <ø> (ø)
...o/customer/messagingpush/ModuleMessagingPushFCM.kt 68.00% <ø> (-1.24%) ⬇️
...ngpush/lifecycle/MessagingPushLifecycleCallback.kt 40.00% <ø> (+18.26%) ⬆️
...ava/io/customer/messagingpush/util/DeepLinkUtil.kt 0.00% <ø> (-8.83%) ⬇️
...push/activity/NotificationClickReceiverActivity.kt 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Build available to test
Version: rehan-push-click-cleanup-SNAPSHOT
Repository: https://s01.oss.sonatype.org/content/repositories/snapshots/

Copy link
Contributor

@levibostian levibostian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎊

Base automatically changed from rehan/push-click-activity to rehan/push-click-behavior September 26, 2023 04:40
@mrehan27 mrehan27 merged commit 47e9512 into rehan/push-click-behavior Sep 26, 2023
@mrehan27 mrehan27 deleted the rehan/push-click-cleanup branch September 26, 2023 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants