Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove workaround for semantic-release issue skipping deployment #262

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

levibostian
Copy link
Contributor

@levibostian levibostian commented Sep 19, 2023

semantic-release has fixed the conventional-commits issue in v22. Therefore, we can remove the workaround from our CI configurations and use the latest version of semantic-release for deployments.

This PR updates the CI config to have the latest version of semantic-release.

@levibostian levibostian requested a review from a team September 19, 2023 19:43
@github-actions
Copy link

github-actions bot commented Sep 19, 2023

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.


  • java_layout: levi/remove-semantic-release-workaround (1695152682)
  • kotlin_compose: levi/remove-semantic-release-workaround (1695152688)

@levibostian levibostian marked this pull request as ready for review September 19, 2023 19:43
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #262 (8887144) into main (a317698) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #262   +/-   ##
=========================================
  Coverage     50.84%   50.84%           
  Complexity      249      249           
=========================================
  Files           108      108           
  Lines          2779     2779           
  Branches        361      361           
=========================================
  Hits           1413     1413           
  Misses         1249     1249           
  Partials        117      117           

@github-actions
Copy link

Build available to test
Version: levi-remove-semantic-release-workaround-SNAPSHOT
Repository: https://s01.oss.sonatype.org/content/repositories/snapshots/

@levibostian levibostian merged commit b6078c0 into main Sep 25, 2023
@levibostian levibostian deleted the levi/remove-semantic-release-workaround branch September 25, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants