Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix the min version for semantic release #266

Merged
merged 2 commits into from
Sep 29, 2023
Merged

Conversation

Shahroz16
Copy link
Contributor

@github-actions
Copy link

github-actions bot commented Sep 28, 2023

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.


  • java_layout: shahroz/fix-cd (1695975221)
  • kotlin_compose: shahroz/fix-cd (1695975221)

@Shahroz16 Shahroz16 requested a review from a team September 28, 2023 11:46
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #266 (ab28ae6) into main (8b9f02a) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #266   +/-   ##
=========================================
  Coverage     50.84%   50.84%           
  Complexity      249      249           
=========================================
  Files           108      108           
  Lines          2779     2779           
  Branches        361      361           
=========================================
  Hits           1413     1413           
  Misses         1249     1249           
  Partials        117      117           

@github-actions
Copy link

Build available to test
Version: shahroz-fix-cd-SNAPSHOT
Repository: https://s01.oss.sonatype.org/content/repositories/snapshots/

Comment on lines 41 to 43
# version should be greater than the 22.0.1 (https://github.com/semantic-release/semantic-release/releases/tag/v22.0.1)
# because previous version had a bug in commit analyzer
semantic_version: 22.0.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# version should be greater than the 22.0.1 (https://github.com/semantic-release/semantic-release/releases/tag/v22.0.1)
# because previous version had a bug in commit analyzer
semantic_version: 22.0.5
semantic_version: latest

@Shahroz16 Shahroz16 merged commit 7588700 into main Sep 29, 2023
@Shahroz16 Shahroz16 deleted the shahroz/fix-cd branch September 29, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants