feat: persistant in-app messages #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.
|
Codecov Report
@@ Coverage Diff @@
## main #269 +/- ##
============================================
+ Coverage 49.76% 50.44% +0.67%
- Complexity 237 249 +12
============================================
Files 108 108
Lines 2781 2809 +28
Branches 364 363 -1
============================================
+ Hits 1384 1417 +33
+ Misses 1282 1275 -7
- Partials 115 117 +2
|
|
Build available to test |
mrehan27
reviewed
Oct 25, 2023
| GistSdk.getUserToken()?.let { userToken -> | ||
| addHeader( | ||
| NetworkUtilities.USER_TOKEN_HEADER, | ||
| Base64.encodeToString(userToken.toByteArray(), Base64.NO_WRAP) |
There was a problem hiding this comment.
Can we keep the comment on it for future reference?
mrehan27
reviewed
Oct 25, 2023
| @@ -61,6 +62,12 @@ class GistModalActivity : AppCompatActivity(), GistListener, GistViewListener { | |||
| } ?: run { | |||
| finish() | |||
| } | |||
|
|
|||
| // Disable back button for persistent messages | |||
There was a problem hiding this comment.
Might need more clarification here, something like this?
Suggested change
| // Disable back button for persistent messages | |
| // Add back button to handle in-app message behavior, enabled false with disable back press for persistent messages |
mrehan27
approved these changes
Oct 25, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Oct 25, 2023
## [3.7.0](3.6.7...3.7.0) (2023-10-25) ### Features * persistant in-app messages ([#269](#269)) ([4fcb781](4fcb781))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gist returns
304when there is no change in queue status, in Android/OKhttp until we haveetagin headers Retrofit doesn't cache and returns the same response. So this adds a workaround where if the response hasn't changed then return the old response for that URL which was returned.This PR has already passed QA testing.