Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add priority field to message and sorting by priority within local store #276

Merged
merged 3 commits into from
Nov 9, 2023

Conversation

BernardGatt
Copy link
Contributor

@BernardGatt BernardGatt requested a review from a team November 7, 2023 14:17
Copy link

github-actions bot commented Nov 7, 2023

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.


  • kotlin_compose: Build failed. See CI job logs to determine the issue and try re-building.
  • java_layout: Build failed. See CI job logs to determine the issue and try re-building.

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #276 (d61728e) into main (c494bb0) will increase coverage by 0.58%.
Report is 20 commits behind head on main.
The diff coverage is 43.26%.

@@             Coverage Diff              @@
##               main     #276      +/-   ##
============================================
+ Coverage     49.76%   50.35%   +0.58%     
- Complexity      237      249      +12     
============================================
  Files           108      108              
  Lines          2781     2810      +29     
  Branches        364      364              
============================================
+ Hits           1384     1415      +31     
+ Misses         1282     1276       -6     
- Partials        115      119       +4     
Files Coverage Δ
...customer/messaginginapp/gist/data/model/Message.kt 54.90% <50.00%> (+1.96%) ⬆️
...main/java/io/customer/sdk/queue/QueueRunRequest.kt 98.00% <97.56%> (+7.61%) ⬆️
...stomer/messaginginapp/gist/presentation/GistSdk.kt 13.17% <33.33%> (+13.17%) ⬆️
...ssaginginapp/gist/presentation/GistModalManager.kt 14.70% <0.00%> (+14.70%) ⬆️
...stomer/messaginginapp/gist/data/listeners/Queue.kt 9.61% <21.42%> (+9.61%) ⬆️
...saginginapp/gist/presentation/GistModalActivity.kt 0.00% <0.00%> (ø)
...inginapp/gist/presentation/engine/EngineWebView.kt 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

Copy link

github-actions bot commented Nov 7, 2023

Build available to test
Version: bernard-sort-local-store-SNAPSHOT
Repository: https://s01.oss.sonatype.org/content/repositories/snapshots/

@levibostian
Copy link
Contributor

@BernardGatt, before you merge this PR, can you fix the CI checks?

I think that you don't have git hooks installed on your development machine? I suggest this because I believe that the "API check" tasks on the CI only fail when local files on your development machine didn't get updated as expected.

I suggest trying to install git hooks, make a new commit and push it up. If you get stuck, I am OK with you merging this PR as-is since it's not introducing any public facing changes to the SDK and then ask the squad in Slack for help fixing the the API checks on main.

@@ -24,7 +24,6 @@ import retrofit2.converter.gson.GsonConverterFactory
class Queue : GistListener {

private var localMessageStore: MutableList<Message> = mutableListOf()
private val cacheMap = mutableMapOf<String, Response>()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Shahroz16 just to confirm, this is not needed right?

Copy link
Contributor

@Shahroz16 Shahroz16 Nov 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BernardGatt yes!! thank you for removing it.

@@ -24,7 +24,6 @@ import retrofit2.converter.gson.GsonConverterFactory
class Queue : GistListener {

private var localMessageStore: MutableList<Message> = mutableListOf()
private val cacheMap = mutableMapOf<String, Response>()
Copy link
Contributor

@Shahroz16 Shahroz16 Nov 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BernardGatt yes!! thank you for removing it.

@BernardGatt BernardGatt merged commit ddb0359 into main Nov 9, 2023
27 of 30 checks passed
@BernardGatt BernardGatt deleted the bernard/sort-local-store branch November 9, 2023 14:24
github-actions bot pushed a commit that referenced this pull request Nov 9, 2023
## [3.7.1](3.7.0...3.7.1) (2023-11-09)

### Bug Fixes

* add priority field to message and sorting by priority within local store ([#276](#276)) ([ddb0359](ddb0359))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants