-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add priority field to message and sorting by priority within local store #276
Conversation
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.
|
Codecov Report
@@ Coverage Diff @@
## main #276 +/- ##
============================================
+ Coverage 49.76% 50.35% +0.58%
- Complexity 237 249 +12
============================================
Files 108 108
Lines 2781 2810 +29
Branches 364 364
============================================
+ Hits 1384 1415 +31
+ Misses 1282 1276 -6
- Partials 115 119 +4
|
Build available to test |
@BernardGatt, before you merge this PR, can you fix the CI checks? I think that you don't have git hooks installed on your development machine? I suggest this because I believe that the "API check" tasks on the CI only fail when local files on your development machine didn't get updated as expected. I suggest trying to install git hooks, make a new commit and push it up. If you get stuck, I am OK with you merging this PR as-is since it's not introducing any public facing changes to the SDK and then ask the squad in Slack for help fixing the the API checks on |
@@ -24,7 +24,6 @@ import retrofit2.converter.gson.GsonConverterFactory | |||
class Queue : GistListener { | |||
|
|||
private var localMessageStore: MutableList<Message> = mutableListOf() | |||
private val cacheMap = mutableMapOf<String, Response>() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Shahroz16 just to confirm, this is not needed right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BernardGatt yes!! thank you for removing it.
@@ -24,7 +24,6 @@ import retrofit2.converter.gson.GsonConverterFactory | |||
class Queue : GistListener { | |||
|
|||
private var localMessageStore: MutableList<Message> = mutableListOf() | |||
private val cacheMap = mutableMapOf<String, Response>() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BernardGatt yes!! thank you for removing it.
## [3.7.1](3.7.0...3.7.1) (2023-11-09) ### Bug Fixes * add priority field to message and sorting by priority within local store ([#276](#276)) ([ddb0359](ddb0359))
Fixes issue: https://github.com/customerio/issues/issues/11663