chore: ensure Android component is initialized from services #451
Conversation
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/react-native-cdp #451 +/- ##
==============================================================
- Coverage 52.25% 52.18% -0.07%
Complexity 291 291
==============================================================
Files 96 96
Lines 2258 2261 +3
Branches 352 352
==============================================================
Hits 1180 1180
- Misses 974 977 +3
Partials 104 104 ☔ View full report in Codecov by Sentry. |
|
|
||
| // TODO: Remove deprecated functions after all usages are removed. | ||
| @Deprecated("Use overrideDependency<Dependency> instead", ReplaceWith("overrideDependency<Dependency>(value)")) | ||
| fun <Dependency : Any> overrideDependency(dependency: Class<Dependency>, value: Dependency) { |
There was a problem hiding this comment.
Removed these as they were deprecated and are no longer used by any DI graph in the SDK
| */ | ||
| fun SDKComponent.registerAndroidSDKComponent( |
There was a problem hiding this comment.
Since the method is intended for internal SDK use only, I renamed it to provide more clarity on its purpose and function.
|
Build available to test |
📏 SDK Binary Size Comparison ReportNo changes detected in SDK binary size ✅ |
core/src/main/kotlin/io/customer/sdk/core/di/SDKComponentExt.kt
Outdated
Show resolved
Hide resolved
Changes
registerAndroidSDKComponenttoensureAndroidComponentfor clearer purposeDiGraph, as they were intended for SDK use only