Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add channelName as option to push config #472

Closed
wants to merge 7 commits into from

Conversation

scotttwittrockcio
Copy link
Contributor

@scotttwittrockcio scotttwittrockcio commented Dec 2, 2024

Enables developer to set the Android messaging channel name via the config.

  • Adds channelName to the config builder
  • Uses channelName to set the channel or falls back to app_name Notifications if no name is set.
  • Updated the java sample app to set the notification channel name via the config

Copy link

github-actions bot commented Dec 2, 2024

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.


@scotttwittrockcio scotttwittrockcio changed the title add channelName as option to push config feat: add channelName as option to push config Dec 2, 2024
Copy link

github-actions bot commented Dec 2, 2024

Build available to test
Version: mbl-700-SNAPSHOT
Repository: https://s01.oss.sonatype.org/content/repositories/snapshots/

Copy link

github-actions bot commented Dec 2, 2024

  • java_layout: mbl-700 (1733182378)

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 51.83%. Comparing base (8b30804) to head (6bcb133).
Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
...messagingpush/CustomerIOPushNotificationHandler.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #472      +/-   ##
============================================
+ Coverage     41.98%   51.83%   +9.85%     
- Complexity      259      291      +32     
============================================
  Files            99       96       -3     
  Lines          2320     2589     +269     
  Branches        344      356      +12     
============================================
+ Hits            974     1342     +368     
+ Misses         1247     1139     -108     
- Partials         99      108       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 2, 2024

  • kotlin_compose: mbl-700 (1733182385)

Copy link

github-actions bot commented Dec 2, 2024

📏 SDK Binary Size Comparison Report

No changes detected in SDK binary size ✅

Copy link

github-actions bot commented Dec 2, 2024

  • java_layout: Build failed. See CI job logs to determine the issue and try re-building.

Copy link

github-actions bot commented Dec 2, 2024

  • kotlin_compose: mbl-700 (1733182664)

Copy link

github-actions bot commented Dec 2, 2024

  • java_layout: mbl-700 (1733183214)

Copy link

github-actions bot commented Dec 2, 2024

  • kotlin_compose: mbl-700 (1733183215)

Copy link

github-actions bot commented Dec 3, 2024

  • java_layout: mbl-700 (1733187167)

Copy link

github-actions bot commented Dec 3, 2024

  • kotlin_compose: mbl-700 (1733187148)

Copy link

github-actions bot commented Dec 3, 2024

  • java_layout: mbl-700 (1733187783)

Copy link

github-actions bot commented Dec 3, 2024

  • kotlin_compose: mbl-700 (1733187772)

Copy link

github-actions bot commented Dec 3, 2024

  • java_layout: mbl-700 (1733188792)

Copy link

github-actions bot commented Dec 3, 2024

  • kotlin_compose: mbl-700 (1733188777)

Copy link

github-actions bot commented Dec 3, 2024

  • java_layout: mbl-700 (1733189052)

Copy link

github-actions bot commented Dec 3, 2024

  • kotlin_compose: mbl-700 (1733189045)

@scotttwittrockcio scotttwittrockcio marked this pull request as ready for review December 9, 2024 18:06
@scotttwittrockcio
Copy link
Contributor Author

I'm closing this PR until we review the project as a whole and get it prioritized as the amount of effort and risk was a bit higher than what was hoping to be a quick fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant