Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update java sample app with screen view configuration #475

Conversation

mrehan27
Copy link
Contributor

part of: MBL-755

Changes

  • Updated Java sample app to allow screenViewUse configuration to be modified from the settings page for testing purposes
  • Set screenViewUse default behavior to align with SDK settings

Screenshot

Screenshot_20241213_204504

@mrehan27 mrehan27 requested a review from Shahroz16 December 13, 2024 20:15
@mrehan27 mrehan27 self-assigned this Dec 13, 2024
Copy link

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.


Copy link

Build available to test
Version: rehan-mbl-755-screen-config-sample-app-SNAPSHOT
Repository: https://s01.oss.sonatype.org/content/repositories/snapshots/

Copy link

  • java_layout: rehan/mbl-755-screen-config-sample-app (1734121005)

Copy link

📏 SDK Binary Size Comparison Report

No changes detected in SDK binary size ✅

Copy link

  • kotlin_compose: rehan/mbl-755-screen-config-sample-app (1734121005)

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.98%. Comparing base (550e220) to head (21b7680).
Report is 1 commits behind head on rehan/mbl-755-screen-config-sdk.

Additional details and impacted files
@@                          Coverage Diff                          @@
##             rehan/mbl-755-screen-config-sdk     #475      +/-   ##
=====================================================================
+ Coverage                              51.94%   51.98%   +0.03%     
- Complexity                               298      299       +1     
=====================================================================
  Files                                     98       98              
  Lines                                   2601     2601              
  Branches                                 356      356              
=====================================================================
+ Hits                                    1351     1352       +1     
+ Misses                                  1142     1140       -2     
- Partials                                 108      109       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrehan27 mrehan27 merged commit a55ecbb into rehan/mbl-755-screen-config-sdk Dec 16, 2024
35 checks passed
@mrehan27 mrehan27 deleted the rehan/mbl-755-screen-config-sample-app branch December 16, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants