chore: fastlane updates to build sample app #137
Conversation
mrehan27
force-pushed
the
rehan/mbl-420-fastlane-updates
branch
from
8403040 to
59557c4
Compare
| require 'json' | ||
|
|
||
| # Fastlane reacts differently by when it gets executed in GitHub Actions. | ||
| class GitHub |
There was a problem hiding this comment.
This is moved to github_helper.rb so we can reuse in multiple repos later
|
|
||
| # example for main builds: `bundle exec fastlane android deploy_app version:1.0.0"` | ||
| # example for develoment builds (pull request, push): `bundle exec fastlane deploy_app` | ||
| lane :deploy_app do |values| |
There was a problem hiding this comment.
Some of this is removed and some moved and updated in build_helper.rb and version_helper.rb
|
|
||
| # Lane to update Flutter app version | ||
| lane :update_flutter_sdk_version do |options| | ||
| project_path = options[:project_path] || File.join(Dir.pwd, '../../..') |
There was a problem hiding this comment.
Is File.join(Dir.pwd, '../../..') safe to use, or do you think it will result in bugs if someone moves a file and something breaks?
I am OK with the code, but I wonder if maybe a UI.message( right above would help if it does break, we can fix it quickly.
| project_path = options[:project_path] || File.join(Dir.pwd, '../../..') | |
| project_path = options[:project_path] || File.join(Dir.pwd, '../../..') | |
| UI.message("updating version for files in path....") |
There was a problem hiding this comment.
Yup, it can surely break if the file is moved. To help with this, there is already a message just below this line:
UI.message("Updating sdk version to #{version_name} in #{project_path}")
Are you suggesting adding another message, or was it just missed?
|
|
||
| # Lane to update Flutter app version | ||
| lane :update_flutter_app_version do |options| | ||
| project_path = options[:project_path] || File.join(Dir.pwd, '..') |
There was a problem hiding this comment.
Same question as above with use of File.join(Dir.pwd, '..')
There was a problem hiding this comment.
There is a message for this one too
UI.message("Updating app versions to #{new_version} in #{project_path}")
| UI.important(find_firebase_app_id(app_identifier: app_package_name)) | ||
|
|
||
| # Build release APK using Flutter CLI | ||
| sh("flutter build apk --release") |
There was a problem hiding this comment.
Do you suggest we build an APK compared to AAB?
There was a problem hiding this comment.
I did consider using AAB as well, but then switched to APK because I think it will be easier for anyone to download from Firebase and install the APK if needed, especially for non-registered devices (e.g., emulators).
|
Great job! |
part of MBL-420
Changes
GemfileandGemfile.lockto include required dependenciesAppfile,Gymfile,MatchfileandPluginfileto match values required by Fastlane to build sample apps on CIFastfileinto following smaller filesbuild_helper.rb-> Helps building and uploading Android and iOS buildsgithub_helper.rb-> Helps fetching Github attributes conveniently (mostly code movement only)version_helper.rb-> Helps updating app and SDK versions on CI