ci: build sample app #138
Merged
ci: build sample app #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.
|
mrehan27
force-pushed
the
rehan/mbl-420-fastlane-updates
branch
from
8403040 to
59557c4
Compare
mrehan27
force-pushed
the
rehan/mbl-420-ci-updates
branch
from
c0db4d5 to
fc4263f
Compare
mrehan27
commented
Aug 9, 2024
levibostian
approved these changes
Aug 12, 2024
Comment on lines
140
to
156
| - name: Setup Android environment for sample app | ||
| uses: ./.github/actions/setup-android | ||
|
|
||
| - name: Build and upload Android app via Fastlane | ||
| uses: maierj/[email protected] | ||
| with: | ||
| subdirectory: apps/${{ matrix.sample-app }} | ||
| lane: 'android build' | ||
| env: | ||
| FIREBASE_APP_DISTRIBUTION_SERVICE_ACCOUNT_CREDS_B64: ${{ secrets.FIREBASE_APP_DISTRIBUTION_SERVICE_ACCOUNT_CREDS_B64 }} | ||
|
|
||
| - name: Setup iOS environment for sample app | ||
| uses: ./.github/actions/setup-ios | ||
| with: | ||
| xcode-version: ${{ env.XCODE_VERSION }} | ||
|
|
||
| - name: Cache CocoaPods downloaded dependencies for faster builds in the future |
There was a problem hiding this comment.
instead of compiling android and ios apps inside of the same job, I suggest separating them into their own job so they can run in parallel. Could speedup the CI running.
There was a problem hiding this comment.
This is a good idea as this will not only speed up the process but also prevent the other app not to fail if one of them is not compiling. But the changes might be larger, I'll do them in another PR later after trying it out for React Native apps first.
Shahroz16
reviewed
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of MBL-420
Changes