chore: update public API #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.
|
Shahroz16
commented
Oct 28, 2024
| required CustomerIOConfig config, | ||
| }) { | ||
| return _customerIO.initialize(config: config); | ||
| static Future<void> initialize({required CustomerIOConfig config}) async { |
There was a problem hiding this comment.
this is still static function, because CustomerIO.instance.initialize didn't look good and then I checked what others could be doing, and saw Firebase also has initialize method as static while others instance bound.
mrehan27
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: https://linear.app/customerio/issue/MBL-618/implement-public-api-structure-for-instance-pattern
changes: