chore: added identify and attributes #163
Merged
+126
−125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shahroz16
changed the base branch from
main
to
feature/data-pipelines-support
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.
|
mrehan27
approved these changes
Nov 7, 2024
| } | ||
|
|
||
| CustomerIO.shared.track(name: name, data: attributes) | ||
| guard let name = params[Keys.Tracking.eventName] as? String |
There was a problem hiding this comment.
Is it possible to revert these formatting changes for commented code? As it could be a bit challenging when merging as I'm working in same file in other ticket.
|
Also, please make sure the failing tests are fixed before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: https://linear.app/customerio/issue/MBL-631/identify-and-attributes
changes: