Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: ensure task fails if any build fails #166

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

mrehan27
Copy link
Contributor

@mrehan27 mrehan27 commented Nov 8, 2024

Changes

  • Modified build sample apps task to fail if either Android or iOS build fails
  • Updated version_helper.rb to align with React Native and prevent failure when time starts with 0

Notes

  • Created PR as I observed an issue in Data Pipelines support changes where tasks didn't fail on individual build failures, leading to false positives.
  • Once merged to main, I'll merge this change to the Data Pipelines feature branch.

@mrehan27 mrehan27 self-assigned this Nov 8, 2024
Copy link

github-actions bot commented Nov 8, 2024

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.


  • amiapp_flutter: 166.1.0 (28851089)

@mrehan27 mrehan27 requested a review from Shahroz16 November 8, 2024 11:42
@mrehan27 mrehan27 merged commit fd8034c into main Nov 8, 2024
6 checks passed
@mrehan27 mrehan27 deleted the rehan/ci-verify-both-builds branch November 8, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants