chore: initialize messaging push module #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.
|
mrehan27
commented
Nov 21, 2024
| requestAlertPermission: false, | ||
| requestBadgePermission: false, | ||
| requestSoundPermission: false, | ||
| ); |
There was a problem hiding this comment.
Updated it to disable push permission on app launch
Shahroz16
approved these changes
Nov 24, 2024
| CustomerIOMessagingPushPlatform get pushMessaging => _pushMessaging; | ||
| static CustomerIOMessagingPushPlatform get pushMessaging { | ||
| if (_instance == null) { | ||
| throw StateError( |
There was a problem hiding this comment.
I am not sure we should be throwing here and crashing, probably just log maybe?
There was a problem hiding this comment.
This is the same how we do for instance in feature branch. Since we need to return a non-null value, we unfortunately can't simply log and continue here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of: MBL-662
Changes
pushMessagingto static property, allowing customers to access it without usinginstanceMessagingPushmodule inAppDelegateand NSECdpApiKeyin iOSEnvfile and updated example iOSEnvfileAPI Update
Before
After