Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor native ios call handling #185

Merged

Conversation

mrehan27
Copy link
Contributor

part of: MBL-658

Changes

  • Moved native call forwarding logic into new extensions, removing redundant code with similar functionality
  • Removed Keys class, replacing single-use cases with hardcoded strings and creating nested private enums for reused cases to improve clarity
  • Added dictionary extensions to extract required values with error logging, reducing redundant code
  • Minor fixes and updates in related code
  • Formatted code to align with the standard formatting used for our native iOS SDK

@mrehan27 mrehan27 self-assigned this Nov 28, 2024
Copy link

github-actions bot commented Nov 28, 2024

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.


  • amiapp_flutter: 185.1.0 (28880405)

Base automatically changed from rehan/mbl-658-ios-renaming to feature/data-pipelines-support November 28, 2024 20:01
@mrehan27 mrehan27 force-pushed the rehan/mbl-658-sdk-ios-refactor branch from a35ede3 to afc3d45 Compare November 28, 2024 20:04
@mrehan27 mrehan27 merged commit 1caad03 into feature/data-pipelines-support Nov 28, 2024
6 checks passed
@mrehan27 mrehan27 deleted the rehan/mbl-658-sdk-ios-refactor branch November 28, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants