Skip to content

Commit

Permalink
ci: call-out SDK diff report 32 byte difference
Browse files Browse the repository at this point in the history
Part of: https://linear.app/customerio/issue/MBL-155/track-the-binary-size-of-our-ios-sdk-upon-every-release

I noticed that some people on the team have opened PRs in the past couple of days and became confused by the diff report generated in their PR. Adding this comment to the diff reports calling out this inaccuracy and link to the ticket where we are trying this inaccuracy to avoid team confusion when they view a diff report.

commit-id:9322d401
  • Loading branch information
levibostian committed Apr 22, 2024
1 parent 5353169 commit fda2dd2
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/build-sample-apps.yml
Original file line number Diff line number Diff line change
Expand Up @@ -199,5 +199,7 @@ jobs:
```
${{ steps.generate-sdk-size-report.outputs.sdk-size-diff-report }}
```
> Note: The SDK diff report above may indicate that the SDK binary size will increase or decrease even if no source code was changed in the PR. See ticket MBL-249 that is tracking this known behavior.
</details>

0 comments on commit fda2dd2

Please sign in to comment.