ci: fix PR report comment hitting max limit of characters #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 15, 2024
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.
|
SDK binary size reports 📊SDK binary size of this PRSDK binary size diff report between this PR and the main branch |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## spr/main/d8fba9fc #700 +/- ##
====================================================
Coverage ? 56.91%
====================================================
Files ? 139
Lines ? 3869
Branches ? 0
====================================================
Hits ? 2202
Misses ? 1667
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Shahroz16
approved these changes
Apr 19, 2024
mrehan27
approved these changes
Apr 19, 2024
ami-aman
approved these changes
Apr 19, 2024
Part of: https://linear.app/customerio/issue/MBL-155/track-the-binary-size-of-our-ios-sdk-upon-every-release The FCM SDK is currently not being calculated in the SDK size reports, only the APN SDK. After this commit, the SDK size reports generated will include the SDKs: CDP, InApp, FCM, and APN. Testing consideration: * Generate a binary report before and after this commit. One report doesn't include FCM SDK source code and the other does. Notes for reviewer: * To get the FCM binary size, I added the FCM SDK into the APN app via SPM. The APN sample app is not using FCM for any of the features at runtime. It's only compiling the FCM SDK into the compiled app. This aligns with what we do in the FCM app where we compile the APN SDK in the app but don't use it at runtime. commit-id:d8fba9fc
Part of: https://linear.app/customerio/issue/MBL-155/track-the-binary-size-of-our-ios-sdk-upon-every-release In the previous commit, there was an error when the CI tried to create a PR comment with all of the SDK size reports in it. The error says it's because the PR comment hit a maximum character limit. To fix this, I removed one of the SDK size reports from the PR comment - the SDK size report that includes dependencies. I chose this solution because this SDK size report is the biggest report there is and also because we currently don't have any metrics tracking our SDK size including dependencies. commit-id:6c6d1d99
levibostian
force-pushed
the
spr/main/d8fba9fc
branch
from
f68b599 to
7f04f2c
Compare
levibostian
force-pushed
the
spr/main/6c6d1d99
branch
from
fba531e to
5353169
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: https://linear.app/customerio/issue/MBL-155/track-the-binary-size-of-our-ios-sdk-upon-every-release
In the previous commit, there was an error when the CI tried to create a PR comment with all of the SDK size reports in it. The error says it's because the PR comment hit a maximum character limit. To fix this, I removed one of the SDK size reports from the PR comment - the SDK size report that includes dependencies. I chose this solution because this SDK size report is the biggest report there is and also because we currently don't have any metrics tracking our SDK size including dependencies.
commit-id:6c6d1d99
Stack: