Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update segment internal SPM dependencies with fixed version #708

Merged
merged 3 commits into from
Apr 24, 2024
Merged

fix: update segment internal SPM dependencies with fixed version #708

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
228a3c3
version bump
Shahroz16 Apr 22, 2024
6c2afda
version parity
Shahroz16 Apr 24, 2024
7d0e2ee
updated comment
Shahroz16 Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ let package = Package(
.package(name: "Firebase", url: "https://github.com/firebase/firebase-ios-sdk.git", "8.7.0"..<"11.0.0"),

// The version is a git commit hash. Make sure the commit is the same as what the DataPipelines CocoaPods is using.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed this comment needs to be updated 😅

.package(name: "Segment", url: "https://github.com/customerio/cdp-analytics-swift.git", .exact("1.5.9+cio.1"))
.package(name: "Segment", url: "https://github.com/customerio/cdp-analytics-swift.git", .exact("1.5.9+cio.2"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need the same change for pods, correct?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we do need to update the podspec files in this PR, too.

I say that because in version 1.5.9+cio.2 of our fork, the Package.swift file was modified to hard-code dependencies. But .podspec file in 1.5.9+cio.2 does not hard-code the dependencies versions.

I think what needs to happen is:

  • Our iOS SDK uses a hard-coded version of our fork in Package.swift and .podspec files.
  • Our fork uses hard-coded versions of dependencies in both Package.swift and .podspec

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both of the versions that you pointed to are not dependent on Segment, they are also CIO forks (Segment don't support their cocoapods) so we are responsible for updating them, and hence even if they are not fixed its okay, they are not in hands of Segment.

Copy link
Contributor Author

@Shahroz16 Shahroz16 Apr 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I update the forks and cocoapods releases to match the same versions, for clarity.

],
targets: [
// Common - Code used by multiple modules in the SDK project.
Expand Down
Loading