-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: fix main branch sample app caching #719
Conversation
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.
|
SDK binary size reports 📊SDK binary size of this PR
SDK binary size diff report between this PR and the main branch
|
I noticed in a recent PR I opened that the CI was not able to download the latest main branch sample app cached build. After scrolling through the long logs, I noticed an action was not called with the correct inputs. Unfortunately, it seems like if an action receives incorrect inputs, it does not throw errors as I expected but it instead continues running. commit-id:f7141b0a
e3096ac
to
6bd7f91
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #719 +/- ##
=======================================
Coverage 56.91% 56.91%
=======================================
Files 139 139
Lines 3869 3869
=======================================
Hits 2202 2202
Misses 1667 1667 ☔ View full report in Codecov by Sentry. |
I noticed in a recent PR I opened that the CI was not able to download the latest main branch sample app cached build. After scrolling through the long logs, I noticed an action was not called with the correct inputs. Unfortunately, it seems like if an action receives incorrect inputs, it does not throw errors as I expected but it instead continues running.