chore: rename message variables to closer represent their purpose in SDK #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of: https://linear.app/customerio/issue/MBL-310/create-a-uikit-uiview-that-displays-an-inline-in-app-message-sent-from As a follow-up to PR: #716, this change renames 2 Message properties to better explain the purpose of the properties in the SDK. Notes to reviewer: * `InAppMessage.messageId` is part of the public API. This change keeps backwards compatibility by not renaming this property.
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.
|
SDK binary size reports 📊SDK binary size of this PRSDK binary size diff report between this PR and the main branch |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/inline-inapp #755 +/- ##
========================================================
- Coverage 66.75% 66.45% -0.30%
========================================================
Files 145 145
Lines 4160 4162 +2
========================================================
- Hits 2777 2766 -11
- Misses 1383 1396 +13 ☔ View full report in Codecov by Sentry. |
|
Original PR I opened was approved. So I will merge into feature branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am creating this PR because the previous one got closed and I cannot re-open it.
Description copied from the closed PR:
Part of: https://linear.app/customerio/issue/MBL-310/create-a-uikit-uiview-that-displays-an-inline-in-app-message-sent-from
As a follow-up to PR: #716, this change renames 2 Message properties to better explain the purpose of the properties in the SDK.
Notes to reviewer:
InAppMessage.messageIdis part of the public API. This change keeps backwards compatibility by not renaming this property.