Skip to content

Commit

Permalink
attempt 2
Browse files Browse the repository at this point in the history
  • Loading branch information
Shahroz16 committed Dec 18, 2024
1 parent 89d6848 commit 42e9efc
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/build-sample-apps.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ name: Build sample apps
on:
pull_request: # build sample apps for every commit pushed to an open pull request (including drafts)
push:
branches: [ test-push-flag ]

concurrency: # cancel previous workflow run if one exists.
group: ${{ github.workflow }}-${{ github.ref }}
Expand Down Expand Up @@ -175,7 +174,7 @@ jobs:
env:
FIREBASE_APP_DISTRIBUTION_SERVICE_ACCOUNT_CREDS_B64: ${{ secrets.FIREBASE_APP_DISTRIBUTION_SERVICE_ACCOUNT_CREDS_B64 }}
continue-on-error: true # continue to build iOS app even if Android build fails

# Update PR comment with build information

- name: Update sample builds PR comment with build information
Expand Down
6 changes: 3 additions & 3 deletions Apps/fastlane/helpers/version_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,9 @@
app_version_code = (current_time.to_f / 60).to_i

UI.message("Generated new versions => SDK: #{sdk_version_name}, App: #{app_version_name} (#{app_version_code})")
sh("echo SDK_VERSION_NAME=#{"5.4.0"} >> $GITHUB_ENV")
sh("echo APP_VERSION_NAME=#{"5.4.0"} >> $GITHUB_ENV")
sh("echo APP_VERSION_CODE=#{"5.4.0"} >> $GITHUB_ENV")
sh("echo SDK_VERSION_NAME=#{sdk_version_name} >> $GITHUB_ENV")
sh("echo APP_VERSION_NAME=#{app_version_name} >> $GITHUB_ENV")
sh("echo APP_VERSION_CODE=#{app_version_code} >> $GITHUB_ENV")
end

# Helper method to update Android version
Expand Down

0 comments on commit 42e9efc

Please sign in to comment.