Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: category not required in screen tracking in ios native module #315

Merged

Conversation

ami-aman
Copy link
Collaborator

@ami-aman ami-aman commented Sep 2, 2024

Linear ticket : https://linear.app/customerio/issue/MBL-450/[android]-update-native-module-to-use-track-event-using-android-cdp

This PR updates react iOS native module to use screen tracking without category as a parameter as per tech doc.

@ami-aman ami-aman changed the base branch from main to feature/cdp-milestone-track-identify September 2, 2024 18:45
@ami-aman ami-aman changed the base branch from feature/cdp-milestone-track-identify to feature/cdp/track-rn September 2, 2024 18:45
Copy link

github-actions bot commented Sep 3, 2024

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.


  • APN: Build failed. See CI job logs to determine the issue and try re-building.
  • FCM: Build failed. See CI job logs to determine the issue and try re-building.

@ami-aman ami-aman changed the base branch from feature/cdp/track-rn to feature/cdp-milestone-track-identify September 3, 2024 16:53
@ami-aman ami-aman marked this pull request as ready for review September 3, 2024 16:55
@ami-aman ami-aman requested a review from a team September 3, 2024 16:55
@ami-aman ami-aman merged commit dcef4f7 into feature/cdp-milestone-track-identify Sep 4, 2024
2 of 8 checks passed
@ami-aman ami-aman deleted the feature/cdp/track-ios branch September 4, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants