Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: logging feature in react native package and ios native module #318

Merged
merged 7 commits into from
Sep 10, 2024

Conversation

ami-aman
Copy link
Collaborator

@ami-aman ami-aman commented Sep 4, 2024

Linear ticket : https://linear.app/customerio/issue/MBL-477/add-logging-support-in-package-ios-and-react-native

Problem

As a developer, I want to have logging support integrated into the package so that I can easily access logs without needing to open Xcode.

Solution

Added logger support in React Native using event emitters from the iOS native module, enabling all native logs to be output to the React Native console. This eliminates the need for customers to open Xcode to retrieve logs, as they currently do.

@ami-aman ami-aman requested a review from a team September 4, 2024 17:14
Copy link

github-actions bot commented Sep 4, 2024

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.


  • FCM: Build failed. See CI job logs to determine the issue and try re-building.
  • APN: Build failed. See CI job logs to determine the issue and try re-building.

ios/wrappers/logging/CioLoggingEmitter.swift Outdated Show resolved Hide resolved
src/native-logger-listener.ts Outdated Show resolved Hide resolved
@ami-aman ami-aman merged commit 7c61244 into feature/cdp-milestone-track-identify Sep 10, 2024
2 of 8 checks passed
@ami-aman ami-aman deleted the feature/cdp/logging branch September 10, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants