Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: register and delete device token in react native & ios #322

Conversation

ami-aman
Copy link
Collaborator

Linear ticket:
https://linear.app/customerio/issue/MBL-505/register-and-delete-already-registered-device-token-in-react-native
https://linear.app/customerio/issue/MBL-506/register-and-delete-token-feature-support-in-ios-native-module

This PR introduces two new methods, registerDeviceToken and deleteDeviceToken, to both the React Native and iOS native modules. These methods have been implemented and tested to ensure proper functionality.

Changes:

React Native Module:

  • Added registerDeviceToken method.
  • Added deleteDeviceToken method.
    iOS Native Module:
  • Implemented registerDeviceToken method.
  • Implemented deleteDeviceToken method.

Purpose:

The purpose of these changes is to provide a more comprehensive device token management solution within the React Native and iOS native modules, enabling better handling of device tokens.

Testing:

Dev testing has been done on the following users:

  • Register device token : User
  • Delete device token : User

Notes:

  • Since there is no test button in our current sample apps, testing was conducted by manually updating the methods on certain existing buttons. This approach may be a limitation for QA testing.

Copy link

github-actions bot commented Sep 13, 2024

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.


  • APN: Build failed. See CI job logs to determine the issue and try re-building.
  • FCM: Build failed. See CI job logs to determine the issue and try re-building.

@ami-aman ami-aman requested a review from a team September 13, 2024 17:12
ios/wrappers/CioRctWrapper.mm Outdated Show resolved Hide resolved
src/customerio-cdp.ts Outdated Show resolved Hide resolved
@ami-aman ami-aman merged commit e4f6776 into feature/cdp-milestone-device-registration Sep 17, 2024
3 of 11 checks passed
@ami-aman ami-aman deleted the feature/device-registration-ios-rn branch September 17, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants