Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: show prompt for push permissions and get push status methods #326

Merged
merged 42 commits into from
Sep 26, 2024

Conversation

ami-aman
Copy link
Collaborator

@ami-aman ami-aman commented Sep 19, 2024

Linear ticket: https://linear.app/customerio/issue/MBL-533/show-push-prompt-and-push-permission-status-in-ios-and-android-rn

Problem:

To provide feature to show push permission prompt and get current status of push permission status using customerio-reactnative package.

Solution:

Provide APIs to fetch current push permission status and show a prompt to request push permissions from the user.

Changes:

This PR includes changes as following:

  • iOS push notification class with API showPromptForPushNotifications and getPushPermissionStatus
  • On TS end, the APIs have been moved from Tracking module to Push module
  • sample app fixes to consume the APIs
  • Android fixes
  • Few Todos have been removed

Screenshots:

android

ami-aman and others added 30 commits August 14, 2024 14:51
Copy link

github-actions bot commented Sep 19, 2024

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.


  • FCM: Build failed. See CI job logs to determine the issue and try re-building.
  • APN: Build failed. See CI job logs to determine the issue and try re-building.

@ami-aman ami-aman requested a review from a team September 19, 2024 12:30
@ami-aman ami-aman changed the title Feature/cdp milestone push inapp chore: show prompt for push permissions and get push status methods Sep 19, 2024
Base automatically changed from feature/cdp-milestone-device-registration to feature/cdp-main September 24, 2024 11:19
src/cio-config.ts Outdated Show resolved Hide resolved
ios/wrappers/utils/CioExtensions.swift Outdated Show resolved Hide resolved
ios/wrappers/push/CioRctPushMessaging.swift Outdated Show resolved Hide resolved
ios/wrappers/push/CioRctPushMessaging.swift Outdated Show resolved Hide resolved
@ami-aman ami-aman merged commit 95c9fab into feature/cdp-main Sep 26, 2024
3 of 11 checks passed
@ami-aman ami-aman deleted the feature/cdp-milestone-push-inapp branch September 26, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants