Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid infinite loops when reading context values at construct time #39

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

kevinkucharczyk
Copy link
Collaborator

Followup to #35

Under certain conditions, a Maximum call stack size exceeded error would be thrown. This could happen when a provider component consumed the same context it also provides, while a nested component reads the context value during initialization (reading in a getter did not exhibit this issue).

Copy link

changeset-bot bot commented Nov 26, 2024

🦋 Changeset detected

Latest commit: f92508e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
ember-provide-consume-context Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kevinkucharczyk kevinkucharczyk merged commit 62b1267 into main Nov 26, 2024
12 checks passed
@kevinkucharczyk kevinkucharczyk deleted the avoid-infinite-loops branch November 26, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant