Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Optional preview window on the side on fzf #14

Merged
merged 2 commits into from
Oct 27, 2024
Merged

✨ Optional preview window on the side on fzf #14

merged 2 commits into from
Oct 27, 2024

Conversation

adia-dev
Copy link

@adia-dev adia-dev commented Oct 26, 2024

  • Introduce new tmux option '@fzf-goto-preview-enabled' to control the preview feature (default: true)
  • Introduce new tmux option '@fzf-goto-preview-{width/height}-preview' to control the preview width and height
  • Update 'main.tmux' to pass the preview option to scripts via an environment variable
  • Modify 'switch_session.sh' and 'switch_session_window.sh' to conditionally include the preview in 'fzf' based on the option
  • Refactor scripts to use arrays for building 'fzf' commands for safer argument handling
  • Fix typos in variable names (e.g., 'defautl' to 'default') and comments
image

- Introduce new tmux option '@fzf-goto-preview-enabled' to control the preview feature (default: true)
- Introduce new tmux option '@fzf-goto-preview-{width/height}-preview' to control the preview width and height
- Update 'main.tmux' to pass the preview option to scripts via an environment variable
- Modify 'switch_session.sh' and 'switch_session_window.sh' to conditionally include the preview in 'fzf' based on the option
- Refactor scripts to use arrays for building 'fzf' commands for safer argument handling
- Fix typos in variable names (e.g., 'defautl' to 'default') and comments
@adia-dev adia-dev changed the title ✨ Add option to enable or disable preview in fzf interface ✨ Optional preview window on the side on fzf Oct 26, 2024
@cutbypham
Copy link
Owner

Thank you, my friend!

@cutbypham cutbypham merged commit ea265c2 into cutbypham:main Oct 27, 2024
@NelsonMaty
Copy link

Hi @adia-dev, great PR! I believe there is a missing file though, scripts/make_new_window.sh.

If you could push it, it would resolve this issue: #15

@adia-dev
Copy link
Author

adia-dev commented Feb 7, 2025

Shoot my bad !!! adding it when I get home.

@adia-dev
Copy link
Author

adia-dev commented Feb 7, 2025

Pushed #17 can somebody check on their side aswell to validate that it works.
It is looking fine on my machine (Mbp M1) 🙂

@NelsonMaty
Copy link

Worked like a charm, thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants