feat: extract component from AFX - simple #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored some logic into ExtractAfxComponentProcessor for easier testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #330.
After some trouble with extracting "partial" afx content as per selection and handling of props found on the extracted content, this is a more simple approach:
a single element under the cursor will be moved "as is" (with all content) to a new prototype at the start of the file (from where it may be moved with #323).
The user will be prompted for a name for the new prototype and warned if the given name is already defined.
Maybe there are some achievable goals in not moving attributes like
@if,@path,@positionetc. or moving multiple selected tags. If they are correctly extracted from the source-code, the needed adjustments should be resonable.So far I didn't get a test working for the refactoring.
resolves #46