Skip to content

feat: improve Neos project detection

Sign in for the full log view
This check has been archived and is scheduled for deletion. Learn more about checks retention
GitHub Actions / Qodana Community for JVM completed Jul 23, 2023 in 0s

197 new problems found by Qodana Community for JVM

Community for JVM

197 new problems were found

Inspection name Severity Problems
@NotNull/@Nullable problems 🔶 Warning 40
Nullability and data flow problems 🔶 Warning 34
Constant values 🔶 Warning 28
Unused import 🔶 Warning 28
Incorrect string capitalization 🔶 Warning 25
Unstable API Usage 🔶 Warning 14
Class is exposed outside of its visibility scope 🔶 Warning 5
Unchecked warning 🔶 Warning 4
Method is identical to its super method 🔶 Warning 3
'equals()' between objects of inconvertible types 🔶 Warning 2
Field may be 'final' 🔶 Warning 2
'size() == 0' can be replaced with 'isEmpty()' 🔶 Warning 2
Unnecessarily escaped character 🔶 Warning 2
Redundant 'Collection.addAll()' call 🔶 Warning 1
Unnecessary 'null' check before method call 🔶 Warning 1
Redundant 'isInstance()' or 'cast()' call 🔶 Warning 1
'String.equals()' can be replaced with 'String.isEmpty()' 🔶 Warning 1
Unnecessary modifier 🔶 Warning 1
Constant values ◽️ Notice 3

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true
Contact Qodana team

Contact us at [email protected]

Details

This result was published with Qodana GitHub Action

Annotations

Check warning on line 12 in src/main/java/de/vette/idea/neos/lang/afx/psi/AfxElementTypes.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Class is exposed outside of its visibility scope 

Class `AfxElementType` is exposed outside its defined visibility scope

Check warning on line 13 in src/main/java/de/vette/idea/neos/lang/afx/psi/AfxElementTypes.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Class is exposed outside of its visibility scope 

Class `AfxElementType` is exposed outside its defined visibility scope

Check warning on line 14 in src/main/java/de/vette/idea/neos/lang/afx/psi/AfxElementTypes.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Class is exposed outside of its visibility scope 

Class `AfxElementType` is exposed outside its defined visibility scope

Check warning on line 9 in src/main/java/de/vette/idea/neos/lang/afx/psi/AfxElementTypes.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Class is exposed outside of its visibility scope 

Class `AfxTagElementType` is exposed outside its defined visibility scope

Check warning on line 10 in src/main/java/de/vette/idea/neos/lang/afx/psi/AfxElementTypes.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Class is exposed outside of its visibility scope 

Class `AfxAttributeElementType` is exposed outside its defined visibility scope

Check warning on line 67 in src/main/java/de/vette/idea/neos/util/PhpElementsUtil.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Redundant 'Collection.addAll()' call 

'addAll()' call can be replaced with parametrized constructor call

Check warning on line 45 in src/main/java/de/vette/idea/neos/errorReporting/SentryErrorReporter.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Constant values 

Condition `ideaEvent.getData() instanceof AbstractMessage` is always `true` when reached

Check warning on line 36 in src/main/java/de/vette/idea/neos/lang/fusion/psi/impl/ext/FusionCopiedPrototypeSignatureImplMixin.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Constant values 

Condition `getParent().getParent() instanceof FusionPropertyCopy` is always `false` when reached

Check warning on line 33 in src/main/java/de/vette/idea/neos/lang/fusion/annotators/PrototypeInheritanceAnnotator.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Constant values 

Condition `element instanceof FusionPropertyCopy` is always `true`

Check warning on line 94 in src/main/java/de/vette/idea/neos/util/NeosUtil.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Constant values 

Condition `parent instanceof FusionPrototypeInstance` is always `true`

Check warning on line 92 in src/main/java/de/vette/idea/neos/lang/fusion/structure/FusionTreeElement.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Constant values 

Condition `!(currentSibling instanceof FusionBlock)` is always `false` when reached

Check warning on line 57 in src/main/java/de/vette/idea/neos/lang/fusion/editor/FusionBreadcrumbsInfoProvider.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Constant values 

Condition `e.getParent() instanceof FusionPropertyCopy` is always `false` when reached

Check warning on line 92 in src/main/java/de/vette/idea/neos/lang/fusion/structure/FusionTreeElement.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Constant values 

Condition `currentSibling != null && !(currentSibling instanceof FusionBlock)` is always `false`

Check warning on line 144 in src/main/java/de/vette/idea/neos/lang/fusion/structure/FusionTreeElement.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Constant values 

Condition `part instanceof FusionMetaProperty` is always `true`

Check warning on line 47 in src/main/java/de/vette/idea/neos/lang/fusion/usages/UsagesTypeProvider.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Constant values 

Condition `parentElement instanceof FusionPrototypeSignature` is always `false`

Check warning on line 57 in src/main/java/de/vette/idea/neos/lang/fusion/editor/FusionBreadcrumbsInfoProvider.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Constant values 

Condition `e instanceof FusionBlock && e.getParent() instanceof FusionPropertyCopy` is always `false`

Check warning on line 36 in src/main/java/de/vette/idea/neos/lang/fusion/psi/impl/ext/FusionCopiedPrototypeSignatureImplMixin.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Constant values 

Result of `getParent().getParent()` is always 'null'

Check warning on line 34 in src/main/java/de/vette/idea/neos/lang/eel/codeInsight/hints/EelInlayParameterHintsProvider.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Constant values 

Condition `element instanceof EelMethodCall` is always `true`

Check warning on line 47 in src/main/java/de/vette/idea/neos/lang/fusion/editor/FusionBreadcrumbsInfoProvider.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Constant values 

Condition `e instanceof FusionSinglePath || e instanceof FusionMetaProperty || e instanceof FusionPrototypeSign...` is always `true`

Check warning on line 49 in src/main/java/de/vette/idea/neos/lang/fusion/usages/PrototypeFindUsagesProvider.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Constant values 

Condition `psiElement instanceof FusionPrototypeSignature` is always `true`

Check warning on line 47 in src/main/java/de/vette/idea/neos/lang/fusion/editor/FusionBreadcrumbsInfoProvider.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Constant values 

Condition `e instanceof FusionSinglePath` is always `true`

Check warning on line 41 in src/main/java/de/vette/idea/neos/lang/fusion/resolve/ref/FusionResourceStringReference.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Constant values 

Condition `getElement() != null` is always `true`

Check warning on line 39 in src/main/java/de/vette/idea/neos/lang/fusion/resolve/ref/FusionStringReference.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Constant values 

Condition `getElement() != null` is always `true`

Check warning on line 81 in src/main/java/de/vette/idea/neos/lang/fusion/editor/FusionBreadcrumbsInfoProvider.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Constant values 

Condition `e instanceof FusionMetaProperty` is always `true`

Check warning on line 77 in src/main/java/de/vette/idea/neos/lang/fusion/usages/PrototypeFindUsagesProvider.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Constant values 

Condition `element instanceof FusionPrototypeSignature` is always `true`
View more details on GitHub Actions