Move the implementation into a consistent namespace libfsst
.
#28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of
fsst
as found inlibfss[12].h/.cpp
currently uses some very common class names likeSymbol
,Decoder
,Encoder
which are very likely to collide with similarly named classes in different libraries and then lead to very nasty violations of the one-definition-rule (ODR). This PR moves all those functions into a namespacelibfsst::
to mitigate these problems.An alternative approach would be to rename this types, e.g.
FsstEncoder
,FsstSymbol
, etc., just tell me, if you prefer that approach.Currently the formatting is very inconsistent, do you have a certain formatting style, or even better a configuration for an autoformatter liike
clang-format
?