Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the implementation into a consistent namespace libfsst. #28

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

joka921
Copy link
Contributor

@joka921 joka921 commented Oct 7, 2024

The implementation of fsst as found in libfss[12].h/.cpp currently uses some very common class names like Symbol, Decoder, Encoder which are very likely to collide with similarly named classes in different libraries and then lead to very nasty violations of the one-definition-rule (ODR). This PR moves all those functions into a namespace libfsst:: to mitigate these problems.

An alternative approach would be to rename this types, e.g. FsstEncoder, FsstSymbol, etc., just tell me, if you prefer that approach.

Currently the formatting is very inconsistent, do you have a certain formatting style, or even better a configuration for an autoformatter liike clang-format?

@peterboncz
Copy link
Collaborator

thanks for the PR -- it is a good idea I think but currently there are very many whitespace changes unrelated to the proposed change. Could you please turn this into a PR with minimal hamming distance? Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants