Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added: Grouping for VPCs on AWS #37

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Added: Grouping for VPCs on AWS #37

wants to merge 6 commits into from

Conversation

xescugc
Copy link
Member

@xescugc xescugc commented Aug 3, 2020 •
edited
Loading

First implementation of Groups for AWS VPC.

TODO:

  • Check for potential Icon for the VPC
  • Do some real tests
  • Check example with more than one VPC if valid

Current result:

graph

Closes #6

@xescugc
provider: Add the 'Groups' function to the Provider
82fb3b0 
It allows the Provider to return the groups of a Resource ID
@xescugc
graph: Add the 'Node.AddGroupIDs'
b7025dc 
That allows to add the GroupIDs in which the Node belongs to
@xescugc
generate: Add the logic to get and set GroupIDs to Nodes
48eb0f9 
This way we have the info on the Node as we want
@xescugc
fixup! generate: Add the logic to get and set GroupIDs to Nodes
263bd57
@xescugc
printer: Add the logic to print GropuIDs with DOT
55009b1 
We use the 'cluster' logic to generate a subgraph, it has it's limitations but it works for now
@xescugc
CHANGELOG: Add Groups logic for VPCs on AWS
eaedd66
@xescugc xescugc self-assigned this Aug 7, 2020
@xlr-8
Copy link

xlr-8 commented Aug 20, 2020

Check for potential Icon for the VPC

The 2 icons that seems common for VPC are:
https://www.iconfinder.com/icons/259280/cloud_copy_non_private_service_specific_virtual_icon
https://freesvg.org/1554244037

Check example with more than one VPC if valid

Having a tfstate / module with more than 1 VPC is completely valid.

xlr-8
xlr-8 reviewed Aug 20, 2020
View reviewed changes
Copy link

@xlr-8 xlr-8 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'd add more complex tfstate:

  1. Multiple VPCs
  2. Empty VPC
  3. Communication cross VPC

I believe the https://github.com/cycloidio/inframap#how-does-it-work would have to be updated too

@tormath1 tormath1 mentioned this pull request Aug 31, 2020
Open
@xescugc xescugc force-pushed the master branch 2 times, most recently from c0bd35f to d9632dd Compare September 3, 2021 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xlr-8 xlr-8 xlr-8 left review comments

Assignees

@xescugc xescugc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AWS Groupping (VPC/Subnets/Region)
2 participants
@xescugc @xlr-8