Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

color of collapse component goes out fix #272

Merged
merged 4 commits into from
May 17, 2024
Merged

color of collapse component goes out fix #272

merged 4 commits into from
May 17, 2024

Conversation

AKHIL-DyC
Copy link
Contributor

@AKHIL-DyC AKHIL-DyC commented May 16, 2024 •
edited
Loading

closes #269

📑 Description

✅ Checks

  • [ ✅] I have updated the documentation as required
  • [✅ ] I have performed a self-review of my code

ℹ Additional context

@AKHIL-DyC AKHIL-DyC requested a review from a team as a code owner May 16, 2024 18:22
@AKHIL-DyC
Copy link
Contributor Author

@petar-cvit

petar-cvit
petar-cvit reviewed May 16, 2024
View reviewed changes
cyclops-ui/src/components/pages/ModuleDetails.tsx Outdated
style={{ backgroundColor: getCollapseColor(collapseKey) }}
style={{
backgroundColor: getCollapseColor(collapseKey),
borderTopLeftRadius: resourceCollapses.length == 0 ? "7px" : "0px",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you checking resourceCollapses.length == 0? Shouldn't it always be 7px? Also, why 7?

Copy link
Contributor Author

@AKHIL-DyC AKHIL-DyC May 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am checking that because ,the second third top radius will be curved so it creates a gap
240517_00h17m31s_screenshot
and 7 because it fitted

@AKHIL-DyC
Copy link
Contributor Author

240517_00h20m57s_screenshot-min
@petar-cvit

@petar-cvit
Copy link
Collaborator

Oh okay, I get it. Good job. Can you add index to the start of that forEach (line 383.) and use that to check if it's the first collapse panel?

@AKHIL-DyC
Copy link
Contributor Author

Oh okay, I get it. Good job. Can you add index to the start of that forEach (line 383.) and use that to check if it's the first collapse panel?

sure ,made changes

petar-cvit
petar-cvit requested changes May 16, 2024
View reviewed changes
cyclops-ui/src/components/pages/ModuleDetails.tsx Outdated
style={{
backgroundColor: getCollapseColor(collapseKey),
borderTopLeftRadius: index == 0 ? "7px" : "0px",
borderTopRightRadius: index == 0 ? "7px" : "7px",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update to "7px" : "0px"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update to "7px" : "0px"?

done

@petar-cvit petar-cvit self-requested a review May 17, 2024 10:27
petar-cvit
petar-cvit approved these changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@petar-cvit petar-cvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AKHIL-DyC

@petar-cvit petar-cvit merged commit dfc6daf into cyclops-ui:main May 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petar-cvit petar-cvit petar-cvit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Color of the Collapse component goes out of border
2 participants
@AKHIL-DyC @petar-cvit