cyclops cli: support for update command #475
Conversation
ashish111333
changed the title
cyctl/internal/update/modules.go
Outdated
|
|
||
| // updates the given module from cyclops API | ||
| // currently supports updating replica count for a module | ||
| func updateModule(clientset *client.CyclopsV1Alpha1Client, moduleName, key string, value int) { |
There was a problem hiding this comment.
Can you make the value type interface?
minor fix
minor fix
minor fix
minor fix
|
have done the requested changes,can you review it now @petar-cvit |
cyctl/internal/update/modules.go
Outdated
| return | ||
|
|
||
| } | ||
| SpecValuesMap := make(map[string]interface{}) |
There was a problem hiding this comment.
rename to specValuesMap
cyctl/internal/update/modules.go
Outdated
| return | ||
|
|
||
| } | ||
| err = unstructured.SetNestedField(SpecValuesMap, value, key) |
There was a problem hiding this comment.
If you have a key that is nested (like scaling.replicas) you will have to split the keys by dots
| err = unstructured.SetNestedField(SpecValuesMap, value, key) | |
| err = unstructured.SetNestedField(SpecValuesMap, value, strings.Split(key, ".")...) |
| fmt.Println("failed to encode to json: ", err) | ||
| return | ||
| } | ||
| module.Spec.Values = apiextensionv1.JSON{Raw: updatedSpecValues} |
There was a problem hiding this comment.
You will also have to populate typeMeta before updating
| module.Spec.Values = apiextensionv1.JSON{Raw: updatedSpecValues} | |
| module.Spec.Values = apiextensionv1.JSON{Raw: updatedSpecValues} | |
| module.TypeMeta = v1.TypeMeta{ | |
| APIVersion: "cyclops-ui.com/v1alpha1", | |
| Kind: "Module", | |
| } |
cyctl/internal/update/modules.go
Outdated
| fmt.Println("failed to update module: ", err) | ||
| return | ||
| } | ||
| fmt.Printf("successfully updated %v", updatedModule.Name) |
There was a problem hiding this comment.
Can you use moduleName without getting it from the updatedModule
| fmt.Printf("successfully updated %v", updatedModule.Name) | |
| fmt.Printf("successfully updated %v", moduleName) |
minor fixes
There was a problem hiding this comment.
@ashish111333 Build is failing because you need to unpack split output using strings.Split(key, ".").... Also, remove unused updatedModule variable
cyctl/internal/update/modules.go
Outdated
| } | ||
|
|
||
| var ( | ||
| UpdateModule = &cobra.Command{ |
There was a problem hiding this comment.
Can you update the name to updateModuleCMD. Update command name in init func as well
build error fix
minor fix
minor fix
minor fix
closes #454
📑 Description
adds support for the updating modules using cyctl cli
✅ Checks
Additional context
cyclops cli currently supports create,delete,describe,get ,this PR adds support for update