Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸš€ feat(cyctl): Show TemplateResolvedVersion on cyctl describe module #610

Closed
wants to merge 1 commit into from

Conversation

ArnavK-09
Copy link
Contributor

closes #605

πŸ“‘ Description

image

βœ… Checks

  • I have tested my code (provide screenshots or screen recordings of a working solution)
  • I have performed a self-review of my code

β„Ή Additional context

is this what expected?

@ArnavK-09 ArnavK-09 requested a review from a team as a code owner October 4, 2024 17:35
@ArnavK-09
Copy link
Contributor Author

@quest-bot loot #605

@quest-bot quest-bot bot added the βš”οΈ Quest Tracks quest-bot quests label Oct 4, 2024
Copy link

quest-bot bot commented Oct 4, 2024

Quest PR submitted! image Quest PR submitted!

@ArnavK-09, you are attempting to solve the issue and loot this Quest. Will you be successful?


Questions? Check out the docs.

@ArnavK-09
Copy link
Contributor Author

@petar-cvit hey, can you confirm is it what expected?

@ArnavK-09 ArnavK-09 changed the title feat(cyctl): Show TemplateResolvedVersion on cyctl describe module πŸš€ feat(cyctl): Show TemplateResolvedVersion on cyctl describe module Oct 4, 2024
@petar-cvit
Copy link
Collaborator

@ArnavK-09, @s-vamshi already reached out to solve this one. When picking issues, pick the ones that nobody started working on. Also, when creating branches for new features, name them to reflect your changes.

Same goes for #608.

@ArnavK-09
Copy link
Contributor Author

@ArnavK-09, @s-vamshi already reached out to solve this one. When picking issues, pick the ones that nobody started working on. Also, when creating branches for new features, name them to reflect your changes.

Same goes for #608.

Oh no, i started working when it wasn't assigned to anybody, and no messages were there, I just forgot to embark it :(

That means my prs are wasted? At least #608 can be accepted if it's valid and I'll change the branch name
? What should I do

@ArnavK-09
Copy link
Contributor Author

@petar-cvit I have changed branch name, should I file pr again if it's valid instead of #608? And could it be merged as I tried :(

@petar-cvit
Copy link
Collaborator

@ArnavK-09, you can close these PRs and if there are no updates from the assignees, you can reopen the PRs from the new branches.

We can't merge these since others already started working on these issues. When picking issues, make sure nobody picked the issue, or if you see somebody picked the issue but there are no updates and you would like to take it, let us know, and we can figure out who to assign the issue to.

@ArnavK-09
Copy link
Contributor Author

sad

@ArnavK-09 ArnavK-09 closed this Oct 6, 2024
Copy link

quest-bot bot commented Oct 10, 2024

🧚 Another solver has looted Quest #605, but your efforts have not gone unnoticed.

Go to https://quira.sh/quests/solver to find a new adventure πŸ—‘

Questions? Check out the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
βš”οΈ Quest Tracks quest-bot quests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show TemplateResolvedVersion on cyctl describe module
2 participants