Shellcheck

cylc · Oct 14, 2024 · 2a3e479 · 2a3e479
1 parent 2206a9b
commit 2a3e479
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 3 deletions.
diff --git a/etc/bin/swarm b/etc/bin/swarm
@@ -145,11 +145,9 @@ prompt () {
         case $USR in
             [Yy])
                 return 0
-                break
                 ;;
             [Nn])
                 return 1
-                break
                 ;;
         esac
     done

diff --git a/tests/flakyfunctional/cylc-poll/16-execution-time-limit.t b/tests/flakyfunctional/cylc-poll/16-execution-time-limit.t
@@ -33,6 +33,7 @@ run_ok "${TEST_NAME_BASE}-validate" cylc validate "${WORKFLOW_NAME}"
 workflow_run_ok "${TEST_NAME_BASE}-run" \
     cylc play --reference-test -v --no-detach "${WORKFLOW_NAME}" --timestamp
 #-------------------------------------------------------------------------------
+# shellcheck disable=SC2317
 cmp_times () {
     # Test if the times $1 and $2 are within $3 seconds of each other.
     python3 -u - "$@" <<'__PYTHON__'

diff --git a/tests/flakyfunctional/xtriggers/00-wall_clock.t b/tests/flakyfunctional/xtriggers/00-wall_clock.t
@@ -18,6 +18,7 @@
 # Test clock xtriggers
 . "$(dirname "$0")/test_header"
 
+# shellcheck disable=SC2317
 run_workflow() {
   cylc play --no-detach --debug "$1" \
     -s "START='$2'" -s "HOUR='$3'" -s "OFFSET='$4'"

diff --git a/tests/functional/lib/bash/test_header b/tests/functional/lib/bash/test_header
@@ -1160,7 +1160,6 @@ for SKIP in ${CYLC_TEST_SKIP}; do
         # Deliberately print variable substitution syntax unexpanded
         # shellcheck disable=SC2016
         skip_all 'this test is in $CYLC_TEST_SKIP.'
-        break
     fi
 done
 

diff --git a/tests/functional/reload/17-graphing-change.t b/tests/functional/reload/17-graphing-change.t
@@ -20,6 +20,7 @@
 #-------------------------------------------------------------------------------
 set_test_number 12
 
+# shellcheck disable=SC2317
 grep_workflow_log_n_times() {
     TEXT="$1"
     N_TIMES="$2"