Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few typos in user & suite guides #2711

Merged
merged 1 commit into from
Jun 30, 2018
Merged

Conversation

kinow
Copy link
Member

@kinow kinow commented Jun 30, 2018

Re-reading the user and suite guides, and taking notes of possible typos (keep in mind English is not my first language :-) ) Let me know if I must update the branch removing any of the typos listed here.

Cheers
Bruno

@kinow kinow changed the title Fix a few typos Fix a few typos in user & suite guides Jun 30, 2018
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Bruno, that's great (it seems English must not be my first language either, from the typos you've found!)

@hjoliver
Copy link
Member

No need for a second review on this one.

@hjoliver hjoliver added this to the next release milestone Jun 30, 2018
@hjoliver hjoliver merged commit fccbdf1 into cylc:master Jun 30, 2018
@kinow
Copy link
Member Author

kinow commented Jul 1, 2018

Thanks Hilary! It is the second time I am reading the docs, and I really like the structure and find it easy to read.

The only thing I am missing is somewhere to refer to find the possible environment variables. Something similar to this page from the Jenkins CI project.

@hjoliver
Copy link
Member

hjoliver commented Jul 1, 2018

I'm not sure if you mean environment variables that affect the operation of the suite server program, or those provided by the server program that can be used in task job environments? Of the former, there aren't any really; of the latter, see the sub-section "Task Execution Environment" and under that, "Task Job Script variables". (This could all be improved, I'm sure ... maybe when we do this: #2651

@kinow
Copy link
Member Author

kinow commented Jul 2, 2018

I was referring to the latter, and the "Task Job Script variables" is exactly what I needed! Thanks!!

@hjoliver
Copy link
Member

hjoliver commented Jul 2, 2018

(You can of course also add arbitrary variables yourself, in task definitions, to task job environments)

@matthewrmshin matthewrmshin added the bug Something is wrong :( label Jul 6, 2018
@matthewrmshin matthewrmshin mentioned this pull request Jul 6, 2018
@kinow kinow deleted the few-typos branch August 31, 2018 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :(
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants